SparseReshape Op#7477
Merged
Merged
Conversation
added 14 commits
February 19, 2021 06:28
Closed
Contributor
Author
|
@tkonolige @mbrookhart PTAL. |
added 3 commits
February 20, 2021 00:55
tkonolige
requested changes
Feb 22, 2021
tkonolige
reviewed
Feb 25, 2021
mbrookhart
approved these changes
Feb 25, 2021
mbrookhart
left a comment
mbrookhart
left a comment
Contributor
There was a problem hiding this comment.
Two minor comments, but overall I'm happy with where this is. @tkonolige anything else you'd like to see?
Contributor
Author
|
@tkonolige All your comments have been resolved. Any other changes you'd like me to make ? |
tkonolige
approved these changes
Feb 25, 2021
tkonolige
left a comment
tkonolige
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Thanks @codeislife99!
Contributor
|
Thanks @codeislife99 @mbrookhart @tkonolige |
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* SparseReshape Inital Code * Done * Format * Add empty tests * Formatting * SanityCheck * formatting documentation * Documentation * Only Enable CPU * Add support for CUDA * Stuff * Add Dynamic Support * Parallelize GPU Impl * Documentation * Documentation * Import * Import * Remove unnecessary code * PR Comments * Schedules * Tests * Dtypes * Black * Parallelize CPU * CI error Co-authored-by: Ubuntu <ubuntu@ip-172-31-42-251.us-east-2.compute.internal>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* SparseReshape Inital Code * Done * Format * Add empty tests * Formatting * SanityCheck * formatting documentation * Documentation * Only Enable CPU * Add support for CUDA * Stuff * Add Dynamic Support * Parallelize GPU Impl * Documentation * Documentation * Import * Import * Remove unnecessary code * PR Comments * Schedules * Tests * Dtypes * Black * Parallelize CPU * CI error Co-authored-by: Ubuntu <ubuntu@ip-172-31-42-251.us-east-2.compute.internal>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds CPU and CUDA implementation for SparseReshape Op and addresses all the issues and feedback from #7125.
Frontend Code for Tensorflow has been added. Corresponding TF Documentation
Note: This PR is a quite long , but most of it are test cases and boiler code. I can split it into CPU and CUDA implementations if you find it easier to review.